fix: add missing breakLease calls in ContractNegotiationProtocolServiceImpl#5788
Merged
Conversation
ndr-brt
added
bug
ronjaquensel
approved these changes
May 29, 2026
ndr-brt
force-pushed
the
5728-missing-breake-lease
branch
from
917412e to
d419ce5
Compare
wolf4ood
approved these changes
May 29, 2026
ndr-brt
force-pushed
the
5728-missing-breake-lease
branch
from
d419ce5 to
7df4834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Add missing
breakLeasein case some validation after entity lease fails.Took the opportunity to refactor the protocol service and some satellite classes.
Also got rid of
ValidatedContractOffer, that was a carrier object for objects that were already available in the caller service, so now thevalidateInitialOfferis just a validator method, and not also a factory.Why it does that
Briefly state why the change was necessary.
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Part of #5728
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.